Switch from static gl generator to struct #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome - I was hoping to do this eventually. |
brendanzab
added a commit
that referenced
this pull request
Aug 20, 2014
Switch from static gl generator to struct
|
Oh, this is amazing! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct gl generator is cleaner, and using it will probably fix some possible crashes when using multiple GL contexts on Windows.
Directly invoking
generate_gl_bindingsalso allows you to directly specify which GL extensions you may wish to use in the future.I had to remove some commas because of rust-lang/rust#14240
Note: I could only try the
gl-initexample (which doesn't draw anything on the screen), but I don't see any reason why the examples would break.